deprecate the cdms2 conversion methods
#7876
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Illviljan
approved these changes
May 29, 2023
|
Thanks you @keewis and @Illviljan! I made comment to deprecate |
|
great, thanks for the confirmation! |
dstansby
pushed a commit
to dstansby/xarray
that referenced
this pull request
Jun 28, 2023
* emit deprecation warnings for the cdms2 conversion methods * add the deprecation notice to the docstring * check that the deprecation warnings are properly raised * actually check that the deprecation message mentions cdms2 * skip cdms2 checks for new numpy / python versions * whats-new entry * make the deprecation message consistent * functions → methods * adjust the skip condition * maintenance mode → deprecated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the
cdms2library has been deprecated and will be retired at the end of this year, maintaining conversion functions does not make sense anymore. Additionally, one of the tests is currently failing on the upstream-dev CI (cdms2is incompatible with a recent change tonumpy), and it seems unlikely this will ever be fixed (and there's nopython=3.11release, blocking us from merging thepy311environment with the default one).cc @tomvothecoder for visibility
whats-new.rst