Support extension array indexes #9671
Conversation
…ore/variable.py to use any-precision datetime/timedelta with autmatic inferring of resolution
…ocessing, raise now early
…t resolution, fix code and tests to allow this
for more information, see https://pre-commit.ci
… more carefully, for now using pd.Series to covert `OMm` type datetimes/timedeltas (will result in ns precision)
…rray` series creating an extension array when `.array` is accessed
| @@ -104,17 +104,11 @@ def index_flat(request): | |||
| index fixture, but excluding MultiIndex cases. | |||
| """ | |||
| key = request.param | |||
| if key in ["bool-object", "bool-dtype", "nullable_bool", "repeats"]: | |||
There was a problem hiding this comment.
there seems to be some weird broadcasting behaviour here.
|
Sorry, this is a total mess. Apparently IndexVariable and Variable now behave differently, and I'm not sure why. |
xarray/core/variable.py
Outdated
| @@ -945,7 +944,7 @@ def load(self, **kwargs): | |||
| -------- | |||
| dask.array.compute | |||
| """ | |||
| self._data = to_duck_array(self._data, **kwargs) | |||
| self._data = _maybe_wrap_data(to_duck_array(self._data, **kwargs)) | |||
There was a problem hiding this comment.
maybe we should just return the PandasExtensionArray wrapper class but I'm wary of exposing that to users
There was a problem hiding this comment.
OK i did this, it seems much neater at the expense of exposing the PandasExtensionArray wrapper class
* main: Bump scientific-python/upload-nightly-action in the actions group (pydata#10192) Add new whats-new section (pydata#10190) release 2025.03.1 (pydata#10188) Support zarr `write_empty_chunks` for zarr-python 3 and up (pydata#10177)
dcherian
changed the title
|
@dcherian Could you give a bit of background into the changes you pushed? I'm not really following.
Did I do something wrong in the PR without knowing it i.e., bypassing the tests? It would be great to understand! |
|
No you didn't do anything wrong per-se.
|
* main: Fix sparse dask repr test (pydata#10200) Apply ruff preview rule RUF046 (pydata#10199) DOC: Remove mention of netcdf pypi package (pydata#10197)
| @@ -102,7 +102,7 @@ def replace_duck_with_extension_array(args) -> list: | |||
| return type(self)[type(res)](res) | |||
| return res | |||
|
|
|||
| def __array_ufunc__(ufunc, method, *inputs, **kwargs): | |||
| def __array_ufunc__(self, ufunc, method, *inputs, **kwargs): | |||
There was a problem hiding this comment.
the test failure in test_units has to do with this implementation for the equals ufunc.
@ilan-gold can you take a look please?
There was a problem hiding this comment.
The signature is correct https://numpy.org/devdocs/user/basics.subclassing.html
I have seen that error before but I can't remember what it means now, maybe a segfault...
There was a problem hiding this comment.
I saw that, but we have self included for __array_ufunc__ inside Xarray 🤷🏾♂️
There was a problem hiding this comment.
ok! hopefully my fix helps, but it was hard to make heads or tails of what changed because the diff was super dirty (there was a merge from main or two). please open a PR into mine in the future, would make things easier :)
github-actions
bot
added
topic-documentation
topic-plotting
topic-NamedArray
| try: | ||
| nbytes_str = f" {render_human_readable_nbytes(variable.nbytes)}" | ||
| except TypeError: | ||
| nbytes_str = " ?" |
There was a problem hiding this comment.
This is a bit ugly, but we'd need to define nbytes on pandas wrappers, and it breaks many reprs in our tests & doctests :/
Identical to kmuehlbauer#1 - probably not very helpful in terms of changes since https://github.com/kmuehlbauer/xarray/tree/any-time-resolution-2 contains most of it....
whats-new.rstapi.rst