Draft
Conversation
Contributor
hollymandel
commented
Nov 24, 2024
hollymandel
commented
- Closes inconsistent 1D interp on 1D and ND DataArrays with NaNs #9702
- Adds a user-level warning when nans detected in interpolation
- Updates test to expect this warning
5 tasks
dcherian
reviewed
Dec 2, 2024
| variables: dict[Hashable, Variable] = {} | ||
| reindex: bool = False | ||
| for name, var in obj._variables.items(): | ||
| if var.isnull().any(): |
Contributor
There was a problem hiding this comment.
ah we can't do this really. I thought the behaviour stemmed from NaNs in the coordinate. Scanning the whole array like this is going to be expensive in many cases.
Contributor
|
Let's close if there are no other ideas, scanning the whole array for NaNs could be quite expensive |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.