Skip to content

Conversation

@Starbuck5
Copy link
Member

@Starbuck5 Starbuck5 commented Jan 5, 2026

I ran the test suite locally and everything checked out.

The warning:

  ..\meson_options.txt:27: WARNING: Project does not target a minimum version but uses feature deprecated since '1.1.0': "boolean option" keyword argument "value" of type str. use a boolean, not a string
  ..\meson_options.txt:31: WARNING: Project does not target a minimum version but uses feature deprecated since '1.1.0': "boolean option" keyword argument "value" of type str. use a boolean, not a string
  ..\meson_options.txt:35: WARNING: Project does not target a minimum version but uses feature deprecated since '1.1.0': "boolean option" keyword argument "value" of type str. use a boolean, not a string

There are also 2 other mesons warnings, one about using fs.relative_to (a relatively recent feature) without declaring a minimum version, and the other about using the built in warning compilation options, but I have not touched those in this PR.

@Starbuck5 Starbuck5 requested a review from a team as a code owner January 5, 2026 04:52
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 5, 2026

📝 Walkthrough

Walkthrough

The pull request updates Meson build system configuration by correcting boolean option types from string literals to actual booleans, introduces a new coverage option, and bumps build tool version constraints in the Python project manifest.

Changes

Cohort / File(s) Summary
Meson boolean options
meson_options.txt
Converts stripped, error_on_warns, and error_docs_missing option default values from string 'false' to boolean false; adds new coverage boolean option with default false
Build tool versions
pyproject.toml
Updates meson upper constraint from <=1.9.1 to <=1.10.0 and cython from <=3.1.4 to <=3.2.4

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately summarizes the main changes: updating meson and cython versions, and fixing meson warnings about boolean option syntax.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description check ✅ Passed The PR description accurately describes the changes made: converting boolean string literals to actual booleans in meson_options.txt and updating dependency versions in pyproject.toml to fix deprecation warnings.
✨ Finishing touches
  • 📝 Generate docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Member

@ankith26 ankith26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! 🎉

@ankith26 ankith26 added this to the 2.5.7 milestone Jan 8, 2026
@ankith26 ankith26 merged commit a0c6f0a into pygame-community:main Jan 8, 2026
28 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants