Skip to content

feat: Add ls fallback support for files.File fact #1384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 23, 2025

Conversation

mrkbac
Copy link
Contributor

@mrkbac mrkbac commented Jun 26, 2025

Add ls fallback support for files.File fact (stat is not available on some embedded systems)

The drawback is the limited timestamps: ls only provides the mtime (as opposed to stat's atime, mtime and ctime).

  • Pull request is based on the default branch (3.x at this time)
  • Pull request includes tests for any new/updated operations/facts
  • Pull request includes documentation for any new/updated operations/facts
  • Tests pass (see scripts/dev-test.sh)
  • Type checking & code style passes (see scripts/dev-lint.sh)

@mrkbac mrkbac marked this pull request as draft June 30, 2025 19:28
Copy link
Member

@Fizzadar Fizzadar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, @mrkbac! Anything still outstanding (checking as it's still a draft)?

@mrkbac mrkbac marked this pull request as ready for review July 13, 2025 16:22
@mrkbac
Copy link
Contributor Author

mrkbac commented Jul 13, 2025

Sorry, yes it's ready

@Fizzadar Fizzadar merged commit c7d5415 into pyinfra-dev:3.x Jul 23, 2025
52 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants