Skip to content

Monkey-patch https://github.com/pyiron/executorlib/pull/943#813

Closed
liamhuber wants to merge 2 commits intoexedebugfrom
internalize-sed
Closed

Monkey-patch https://github.com/pyiron/executorlib/pull/943#813
liamhuber wants to merge 2 commits intoexedebugfrom
internalize-sed

Conversation

@liamhuber
Copy link
Member

No description provided.

Signed-off-by: liamhuber <liamhuber@greyhavensolutions.com>
@liamhuber liamhuber mentioned this pull request Mar 2, 2026
@github-actions
Copy link

github-actions bot commented Mar 2, 2026

Binder 👈 Launch a binder notebook on branch pyiron/pyiron_workflow/internalize-sed

@liamhuber
Copy link
Member Author

I'll first let it roll to see if it causes any new problems, and whether it solves the simple integration test problem. If it does, I'll roll back the sed clause in the slurm tests and see if it still works. If all those are green lights, then I guess pyiron/executorlib#943 will resolve everything here 🤞

@liamhuber
Copy link
Member Author

Well, what I did re-introduced the failure on the slurm test, which is sad

@liamhuber
Copy link
Member Author

Aha, because in my short-circuit I left out an intermediate step

Signed-off-by: liamhuber <liamhuber@greyhavensolutions.com>
@liamhuber
Copy link
Member Author

Ah, sadly this attack is misguided. The patch targets a task scheduler, but I am mixing in a new class inheriting from BaseExecutor with the NodeSlurmExecutor. While these also have a shutdown method for me to override, they don't have the same properties as the task scheduler in the base patch and I hit: AttributeError: 'NodeSlurmExecutor' object has no attribute '_process'

@liamhuber liamhuber closed this Mar 2, 2026
@liamhuber liamhuber deleted the internalize-sed branch March 2, 2026 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant