Debug Executorlib - Alternative strategy

[jan-janssen]

No description provided.

[github-actions]

👈 Launch a binder notebook on branch pyiron/pyiron_workflow/exedebug2

[liamhuber]

The direction of this attack seems good to me.

pyiron_workflow.mixin.run.ReadinessError: child_class_with_all_methods_implemented received a run command but is not ready. The runnable should be neither running nor failed.

I guess the weakening of the self.running = False was too extreme, but I need to re-read to try and see why as it looked OK to me at first-pass.

[liamhuber]

I guess the finally: self._run_finally(**run_finally_kwargs) clause is killing us, because it's being run even in the branch where the future is cancelled.

This callback has been anticipating to run when the output is finished (either successfully or in an error), and now we call it when shutting down the executor. I.e. it's being invoked prematurely.

ATM my best understanding is that we want to ignore the callback on future cancellation, but otherwise retain the try/except/finally pattern to handle the future raising an error.

[liamhuber]

Closed in favour of #816