-
Notifications
You must be signed in to change notification settings - Fork 173
[ENH] Improve conditional_join with cython #1494
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## dev #1494 +/- ##
==========================================
- Coverage 83.49% 75.49% -8.00%
==========================================
Files 88 100 +12
Lines 6469 7895 +1426
==========================================
+ Hits 5401 5960 +559
- Misses 1068 1935 +867 🚀 New features to boost your workflow:
|
be04583 to
67e7db0
Compare
|
@ericmjl given the size of this PR, I will close it and create smaller PR chunks. What are your thoughts? Your thoughts on the cython inclusion? If it were implemented in rust would that be ok (possibly useful for Polars extensions for some of our Polars functions)? |
PR Description
Please describe the changes proposed in the pull request:
This PR resolves #1490 .
Example (as always with benchmarks/tests, take with a pinch of salt YMMV):
PR Checklist
Please ensure that you have done the following:
<your_username>:dev, but rather from<your_username>:<feature-branch_name>.AUTHORS.md.CHANGELOG.mdunder the latest version header (i.e. the one that is "on deck") describing the contribution.Automatic checks
There will be automatic checks run on the PR. These include:
Relevant Reviewers
Please tag maintainers to review.