Skip to content

Fix PassThruConnect Flags for 11 bit CAN identifier #288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix PassThruConnect Flags for 11 bit CAN identifier #288

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions udsoncan/j2534.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,8 @@ def __init__(self, windll, rxid, txid):
self.rxid = rxid.to_bytes(4, 'big')
self.txid = txid.to_bytes(4, 'big')
# Determine mode ID29 or ID11
self.txConnectFlags = TxStatusFlag.ISO15765_CAN_ID_29.value if txid >> 11 else TxStatusFlag.ISO15765_CAN_ID_11.value
# If CAN identifier length is 29 bit set the proper flag
self.txConnectFlags = TxStatusFlag.ISO15765_CAN_ID_29.value if txid >> 11 else 0
self.txFlags = self.txConnectFlags | TxStatusFlag.ISO15765_FRAME_PAD.value

self.logger = logging.getLogger()
Expand Down Expand Up @@ -357,7 +358,6 @@ class Filter(Enum):
class TxStatusFlag(Enum):
ISO15765_CAN_ID_BOTH = 0x00000800
ISO15765_CAN_ID_29 = 0x00000100
ISO15765_CAN_ID_11 = 0x00000040
ISO15765_FRAME_PAD = 0x00000040
WAIT_P3_MIN_ONLY = 0x00000200
SW_CAN_HV_TX = 0x00000400 # OP2.0: Not supported
Expand Down