Fix modutils._get_relative_base_path returns incorrect result when directory name starts with directory name in path_to_check #2756
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests β
Additional details and impacted files@@ Coverage Diff @@
## main #2756 +/- ##
=======================================
Coverage 93.29% 93.30%
=======================================
Files 93 93
Lines 11085 11090 +5
=======================================
+ Hits 10342 10347 +5
Misses 743 743
Flags with carried forward coverage won't be shown. Click here to find out more.
π New features to boost your workflow:
|
|
@pavan-msys Do you think it is possible to get full coverage on this diff? |
|
Hi @DanielNoord Thanks for the feedback! I added the missing edge test case after the initial coverage was completed, so the current diff should now have full coverage. |
DanielNoord
approved these changes
Jun 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Changes
Description
This PR fixes a bug in
astroid.modutils._get_relative_base_pathwhere the function would incorrectly return a partial subpath if the target path started with the same prefix aspath_to_check, but was not actually a subdirectory.Closes #2608