-
Notifications
You must be signed in to change notification settings - Fork 120
Update versions of Python and Django #469
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but waiting for @carlio 's opinion on this one.
Pull Request Test Coverage Report for Build 18520668020Details
💛 - Coveralls |
1 similar comment
Pull Request Test Coverage Report for Build 18520668020Details
💛 - Coveralls |
It's difficult to know as the CI is still broken but at least this should remove the CI config for the versions being removed. Personally I like supporting older stuff since it's always been my view that the code in need of linting the most is the legacy code running old versions of dependencies. Linting new projects with new dependencies but not linting 5-year-old code means those legacy codebases don't have the tooling required to improve and, as someone who often has to deal with and upgrade that kind of codebase, I don't want support from my tools to disappear! Legacy code upgrades are a very important use case for pylint and similar imo... |
First and foremost: I have no intent of doing a drive by change of fundamental principles. I'm just trying my best to help – and I don't feel attacked at all, just clarifying ✌️
I don't have enough knowledge about the CI setup here: Why is it still testing against Django version that are removed in this PR?
I don't disagree with this at all. And I appreciate the concern for the process of upgrading old codebases. But working with a 5 year old Django, you can still use the linting tools from back then (and probably a bit into the future from then) and get a long way. I'm working on a 10 year old codebase myself, so I feel the pain once in a while :) Anyway: CI is currently blocking an upgrade to support pylint 4.x. This was an attempt at cleaning that up, but it clearly didn't work. Feel free to reject this PR if/as something else is needed to get CI working. Let me know if there's something else I can do in that regard. |
The GitHub actions are defined here: https://github.com/pylint-dev/pylint-django/blob/master/.github/workflows/build.yml#L79 That has the three ("latest", "maintained" and "deprecated") so that's the config you need to change to drop or move support around. |
I did my best at updating the dependencies of Django and Python to only be those that are not EOL (including Django 6.0, which is currently in alpha and expected to land in a couple of months).