Skip to content

Conversation

decibyte
Copy link

I did my best at updating the dependencies of Django and Python to only be those that are not EOL (including Django 6.0, which is currently in alpha and expected to land in a couple of months).

Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but waiting for @carlio 's opinion on this one.

@coveralls
Copy link

coveralls commented Oct 16, 2025

Pull Request Test Coverage Report for Build 18520668020

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-85.3%) to 0.0%

Totals Coverage Status
Change from base Build 17751474096: -85.3%
Covered Lines: 0
Relevant Lines: 0

💛 - Coveralls

1 similar comment
@coveralls
Copy link

Pull Request Test Coverage Report for Build 18520668020

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-85.3%) to 0.0%

Totals Coverage Status
Change from base Build 17751474096: -85.3%
Covered Lines: 0
Relevant Lines: 0

💛 - Coveralls

@carlio
Copy link
Member

carlio commented Oct 16, 2025

It's difficult to know as the CI is still broken but at least this should remove the CI config for the versions being removed.

Personally I like supporting older stuff since it's always been my view that the code in need of linting the most is the legacy code running old versions of dependencies. Linting new projects with new dependencies but not linting 5-year-old code means those legacy codebases don't have the tooling required to improve and, as someone who often has to deal with and upgrade that kind of codebase, I don't want support from my tools to disappear!

Legacy code upgrades are a very important use case for pylint and similar imo...

@decibyte
Copy link
Author

First and foremost: I have no intent of doing a drive by change of fundamental principles. I'm just trying my best to help – and I don't feel attacked at all, just clarifying ✌️

It's difficult to know as the CI is still broken but at least this should remove the CI config for the versions being removed.

I don't have enough knowledge about the CI setup here: Why is it still testing against Django version that are removed in this PR?

Personally I like supporting older stuff since it's always been my view that the code in need of linting the most is the legacy code running old versions of dependencies. Linting new projects with new dependencies but not linting 5-year-old code means those legacy codebases don't have the tooling required to improve and, as someone who often has to deal with and upgrade that kind of codebase, I don't want support from my tools to disappear!

I don't disagree with this at all. And I appreciate the concern for the process of upgrading old codebases. But working with a 5 year old Django, you can still use the linting tools from back then (and probably a bit into the future from then) and get a long way. I'm working on a 10 year old codebase myself, so I feel the pain once in a while :)

Anyway: CI is currently blocking an upgrade to support pylint 4.x. This was an attempt at cleaning that up, but it clearly didn't work. Feel free to reject this PR if/as something else is needed to get CI working. Let me know if there's something else I can do in that regard.

@carlio
Copy link
Member

carlio commented Oct 17, 2025

The GitHub actions are defined here: https://github.com/pylint-dev/pylint-django/blob/master/.github/workflows/build.yml#L79

That has the three ("latest", "maintained" and "deprecated") so that's the config you need to change to drop or move support around.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants