Skip to content

Conversation

@juanitorduz
Copy link
Collaborator

@juanitorduz juanitorduz commented Nov 12, 2025

Show the examples in a gallery mode following the approach of pymc-labs/pymc-marketing#1611

image

📚 Documentation preview 📚: https://causalpy--558.org.readthedocs.build/en/558/

@codecov
Copy link

codecov bot commented Nov 12, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.50%. Comparing base (921c9f7) to head (cd069cc).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #558   +/-   ##
=======================================
  Coverage   96.50%   96.50%           
=======================================
  Files          31       31           
  Lines        4173     4173           
=======================================
  Hits         4027     4027           
  Misses        146      146           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@juanitorduz juanitorduz marked this pull request as draft November 12, 2025 19:13
@juanitorduz juanitorduz self-assigned this Nov 12, 2025
@juanitorduz juanitorduz added the documentation Improvements or additions to documentation label Nov 12, 2025
@juanitorduz juanitorduz marked this pull request as ready for review November 12, 2025 19:35
@drbenvincent
Copy link
Collaborator

That is nice. Can only look on my phone now, will review tomorrow.

ancova_pymc.ipynb
## ANCOVA

Analysis of covariance is a simple linear model, typically with one continuous predictor (the covariate) and a categorical variable (which may correspond to treatment or control group). In the context of this package, ANCOVA could be useful in pre-post treatment designs, either with or without random assignment. This is similar to the approach of difference in differences, but only applicable with a single pre and post treatment measure.
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@drbenvincent feel free to push edits to these descriptions :)

Copy link
Collaborator Author

@juanitorduz juanitorduz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On model descriptions :)

Copy link
Collaborator

@drbenvincent drbenvincent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this. Here's quick, first-pass review.

  1. The left nabber feels rather empty now. It is possible to kill that? Or move the navigation (on the right) to the left and kill the right nav bar?

  2. I notice the menu is now "Example Gallery" rather than "How-to". Don't know if I have strong feelings either way, but it's worth seeing if a consensus favourite emerges. If we switch I guess we should grep for any mentions of "how-to".

  3. Can you give a thorough enough description in CONTRIBUTING.md and AGENTS.md so that it's clear what to do when there's a new notebook.

I'll take a look at, and maybe edit, the descriptions in another round.

@juanitorduz
Copy link
Collaborator Author

Thanks @drbenvincent ! Regarding your comments:

The left nabber feels rather empty now. It is possible to kill that? Or move the navigation (on the right) to the left and kill the right nav bar?

-> Added a table of contents on the side.

I notice the menu is now "Example Gallery" rather than "How-to". Don't know if I have strong feelings either way, but it's worth seeing if a consensus favourite emerges. If we switch I guess we should grep for any mentions of "how-to".

-> Reverted back to how-to for now.

Can you give a thorough enough description in CONTRIBUTING.md and AGENTS.md so that it's clear what to do when there's a new notebook.

done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants