Skip to content

Conversation

fdrgsp
Copy link
Contributor

@fdrgsp fdrgsp commented Jan 29, 2025

In this PR, @tlambert03 and I started working on integrating ndv into the GUI to display the MDAs.

Still a lot of work to do...

Screen.Recording.2025-01-28.at.11.08.37.PM.mov

Copy link

codecov bot commented Jan 31, 2025

Codecov Report

Attention: Patch coverage is 95.45455% with 3 lines in your changes missing coverage. Please review.

Project coverage is 85.18%. Comparing base (1454172) to head (17f2fcd).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/pymmcore_gui/_ndv_viewers.py 95.31% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #19      +/-   ##
==========================================
+ Coverage   84.48%   85.18%   +0.69%     
==========================================
  Files          17       18       +1     
  Lines         980     1046      +66     
==========================================
+ Hits          828      891      +63     
- Misses        152      155       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tlambert03 tlambert03 changed the title [WIP] feat: add ndv viewer for MDA feat: add ndv viewer for MDA [WIP] Feb 1, 2025
@tlambert03 tlambert03 changed the title feat: add ndv viewer for MDA [WIP] feat: add ndv viewer for MDA Feb 5, 2025
@tlambert03
Copy link
Member

awesome! thanks @fdrgsp

follow up things to do:

  • tabs for various viewers (generally think about how to manage multiple viewing frames... lots to discuss there.
  • support 5D base (feat: Support 5D writer base [WIP] #32)
  • make sure image preview is not triggered during MDA (can happen on first and last frame)

@tlambert03 tlambert03 mentioned this pull request Feb 5, 2025
3 tasks
@tlambert03 tlambert03 merged commit 95c4ed3 into pymmcore-plus:main Feb 5, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants