Skip to content

Conversation

@tlambert03
Copy link
Member

fixes #363

This is just a patch for the immediate issue, these widgets still contain a lot of duplicated code and possible bugs, and should be replaced (with one of #307, #320, #338, etc...)

@codecov
Copy link

codecov bot commented Oct 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.69%. Comparing base (7b074d3) to head (9a7c04a).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #365      +/-   ##
==========================================
- Coverage   90.74%   90.69%   -0.05%     
==========================================
  Files          79       80       +1     
  Lines        9209     9160      -49     
==========================================
- Hits         8357     8308      -49     
  Misses        852      852              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tlambert03 tlambert03 merged commit e52a8bc into pymmcore-plus:main Oct 4, 2024
20 checks passed
@tlambert03 tlambert03 deleted the fix-group-preset branch October 4, 2024 16:27
@tlambert03 tlambert03 added the bug Something isn't working label Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Device name with "-" crashes GroupPresetWidget

1 participant