feat: yet another config group editor iteration #451
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ConfigGroupsModel fix: update icon names for AutoFocus and Magnifier device types refactor: enhance PropertyValueDelegate and ConfigGroupsEditor for better structure and functionality
…and presets - Added QConfigGroupsModel to handle a three-level model structure for configuration groups, presets, and settings. - Implemented _Node class to represent tree nodes for groups, presets, and settings. - Enhanced data handling and editing capabilities within the model. - Updated related views and widgets to utilize the new model structure. - Refactored existing code to improve clarity and maintainability, including renaming and restructuring imports. - Adjusted tests to align with the new model and property handling.
…tree model handling
- Removed the unused ConfigGroupsEditor import from __init__.py and updated the import for ConfigGroupsEditor from the correct module. - Deleted the _config_views.py file, which contained the ConfigGroupsEditor class and related functionality, to streamline the codebase. - Refactored the DevicePropertySelector to utilize a new DeviceTypeFilter class for filtering device types, improving code organization and readability. - Introduced a new _device_type_filter_proxy.py file containing the DeviceTypeFilter class, which manages filtering based on allowed device types and property flags. - Updated the DevicePropertySelector to connect the new filtering logic to the UI components, ensuring proper functionality with the new structure.
… editor refactor: improve icon handling and toolbar actions in config groups editor refactor: enhance QConfigGroupsModel to manage channel groups refactor: streamline device property selector and view mode toggling
…n ConfigGroupPivotModel
…perty handling in models
tlambert03
changed the title
Codecov ReportAttention: Patch coverage is
❌ Your patch check has failed because the patch coverage (23.39%) is below the target coverage (85.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #451 +/- ##
==========================================
- Coverage 87.45% 80.45% -7.00%
==========================================
Files 105 114 +9
Lines 11477 12854 +1377
==========================================
+ Hits 10037 10342 +305
- Misses 1440 2512 +1072 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
yet another evolution of #446
Screen.Recording.2025-07-06.at.5.12.46.PM.mov
again, @marktsuchida ... would love your feedback. (anything you already noted in #446 (comment) doesn't need to be repeated here... I still intend to comb that for remaining todo items). But the interface has changed significantly. curious to hear your thoughts