Skip to content

MAINT passthrough the lockfile object from the manager into freeze function #212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 27, 2025

Conversation

ryanking13
Copy link
Member

Related: #112

Updates the freeze API to pass the lockfile into the child functions. No functional changes are included.

The goal of this PR is to gradually eliminate the from ._compat import ... syntax from non-manager codes. Instead, the manager object will drill in the compatibility layer to child functions.

@ryanking13 ryanking13 changed the title MAINT passthrough the lockfile object from the manager in freeze function MAINT passthrough the lockfile object from the manager into freeze function Feb 20, 2025
Copy link
Member

@agriyakhetarpal agriyakhetarpal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @ryanking13!

@ryanking13 ryanking13 merged commit eefb57a into pyodide:main Jun 27, 2025
3 of 5 checks passed
@ryanking13
Copy link
Member Author

Thanks for the review!

@ryanking13 ryanking13 deleted the to-manager-method branch June 27, 2025 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants