- 
                Notifications
    
You must be signed in to change notification settings  - Fork 7
 
[RTR] BioBuddy interface #77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
          
 If "False" is sent as update_kinematics, then is does not cost much. That said, getting all at the same time is definitely more elegant 
 Yep  | 
    
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Ipuch reviewed 5 of 5 files at r1, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @EveCharbie)
pyorerun/__init__.py line 23 at r1 (raw file):
) except ImportError: # BioBuddy is not installed, these classes will not be available
if you want to make a hard dependancy it's okay.
Code quote:
    from .model_interfaces import (
        BiobuddyModel,
        BiobuddyModelNoMesh,
    )
except ImportError:
    # BioBuddy is not installed, these classes will not be availableexamples/biobuddy/models/Wu_Shoulder_Model_kinova_scaled_adjusted_2.bioMod line 1 at r1 (raw file):
version 4
modified this after the paths and the biorbd interface.
pyorerun/model_interfaces/__init__.py line 15 at r1 (raw file):
from .biobuddy_model_interface import BiobuddyModelNoMesh, BiobuddyModel except ImportError: # BioBuddy is not installed, these classes will not be available
same comment
Code quote:
try:
    from .osim_model_interface import OsimModelNoMesh, OsimModel
except ImportError:
    # OpenSim is not installed, these classes will not be available
    pass
# Biobuddy
try:
    from .biobuddy_model_interface import BiobuddyModelNoMesh, BiobuddyModel
except ImportError:
    # BioBuddy is not installed, these classes will not be available| 
           @EveCharbie I don't remember what was the pb here, do you remember?  | 
    
| 
           @Ipuch The problem was the model duplicate. I just fixed it. Let me know if it's OK for you :)  | 
    
| 
           One final requirement for me to merge safely. I need to know to which version of biobuddy we need to stick. 
 
  | 
    
| 
           Made the requested changes, will have to wait tonight to publish the new version on pip  | 
    
Answering to Issue #62
I have some questions:
rangesorrangesqor both recognized by biorbd ?This change is