-
Notifications
You must be signed in to change notification settings - Fork 292
feat: support uv with Android #2587
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
a400b8e to
18c45a5
Compare
|
@mhsmith, does this seem reasonable? I'll be in India for a week, so feel free to edit as needed. |
|
Looks good so far. A few comments:
|
18c45a5 to
7b4079b
Compare
|
Looks like we need to translate pip's
|
ee40809 to
a0350fa
Compare
| wheels = cibuildwheel_run( | ||
| tmp_path, | ||
| add_env={**cp313_env, "CIBW_BUILD_FRONTEND": "build"}, | ||
| add_env={**cp313_env, **build_frontend_env, "CIBW_TEST_COMMAND": "python -m site"}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests with a test command need to be decorated with @needs_emulator, so they'll be skipped on the CI platforms that don't support that.
But maybe this test doesn't need a test command at all. OK, I guess it does need one in order to check the test environment installed by uv. But this command doesn't actually use the environment.
d1bc6a3 to
4cccafa
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good, but the CI failure seems relevant?
Signed-off-by: Henry Schreiner <[email protected]>
Signed-off-by: Henry Schreiner <[email protected]>
Signed-off-by: Henry Schreiner <[email protected]>
This reverts commit dbf3385.
Signed-off-by: Henry Schreiner <[email protected]>
Signed-off-by: Henry Schreiner <[email protected]>
Signed-off-by: Henry Schreiner <[email protected]>
Signed-off-by: Henry Schreiner <[email protected]>
Signed-off-by: Henry Schreiner <[email protected]>
4cccafa to
9b95e03
Compare
Now supported in the latest uv release.