Skip to content

feat: config settings placeholders#2827

Open
henryiii wants to merge 2 commits intomainfrom
henryiii/fix/confsetplace
Open

feat: config settings placeholders#2827
henryiii wants to merge 2 commits intomainfrom
henryiii/fix/confsetplace

Conversation

@henryiii
Copy link
Copy Markdown
Contributor

Suggested on discord.

🤖 Assisted-by: Copilot:GPT-5.4

Assisted-by: Copilot:GPT-5.4
Signed-off-by: Henry Schreiner <henryfs@princeton.edu>
Copy link
Copy Markdown
Contributor

@freakboy3742 freakboy3742 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fairly straightforward - the only potential issue I can see on the iOS end (and it would be the same for Android and Emscripten) would be whether there's a need to reference a path that is relative to target machine - but AFAICT, the args being interpreted here are always going to be build arguments, so that won't be a factor.

Copy link
Copy Markdown
Member

@agriyakhetarpal agriyakhetarpal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @henryiii! One comment about the example being added, but this should work for my needs pretty well.

Comment thread docs/options.md
Co-authored-by: agriya khetarpal <74401230+agriyakhetarpal@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants