-
Notifications
You must be signed in to change notification settings - Fork 226
feat: manylinux_2_39_aarch64, manylinux_2_39_riscv64 & musllinux_1_2_riscv64 #1743
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change | ||||||||
---|---|---|---|---|---|---|---|---|---|---|
|
@@ -53,6 +53,19 @@ elif [ "${POLICY}" == "manylinux_2_35" ]; then | |||||||||
DEVTOOLSET_ROOTPATH= | ||||||||||
PREPEND_PATH= | ||||||||||
LD_LIBRARY_PATH_ARG= | ||||||||||
elif [ "${POLICY}" == "manylinux_2_39" ]; then | ||||||||||
BASEIMAGE="quay.io/almalinuxorg/almalinux:10" | ||||||||||
case "${PLATFORM}" in | ||||||||||
x86_64) GOARCH="amd64/v2";; | ||||||||||
riscv64) BASEIMAGE="rockylinux/rockylinux:10";; | ||||||||||
esac | ||||||||||
# TODO enable gcc-toolset-15 once available (probably in 10.1) | ||||||||||
# DEVTOOLSET_ROOTPATH="/opt/rh/gcc-toolset-15/root" | ||||||||||
# PREPEND_PATH="/usr/local/bin:${DEVTOOLSET_ROOTPATH}/usr/bin:" | ||||||||||
# LD_LIBRARY_PATH_ARG="${DEVTOOLSET_ROOTPATH}/usr/lib64:${DEVTOOLSET_ROOTPATH}/usr/lib:${DEVTOOLSET_ROOTPATH}/usr/lib64/dyninst:${DEVTOOLSET_ROOTPATH}/usr/lib/dyninst" | ||||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. [nitpick] There are commented-out toolchain configuration lines for gcc-toolset-15. Consider removing these commented lines or adding a TODO comment explaining why they're preserved for future reference.
Suggested change
Copilot uses AI. Check for mistakes. Positive FeedbackNegative Feedback |
||||||||||
DEVTOOLSET_ROOTPATH= | ||||||||||
PREPEND_PATH= | ||||||||||
LD_LIBRARY_PATH_ARG= | ||||||||||
elif [ "${POLICY}" == "musllinux_1_2" ]; then | ||||||||||
BASEIMAGE="alpine:3.22" | ||||||||||
DEVTOOLSET_ROOTPATH= | ||||||||||
|
Original file line number | Diff line number | Diff line change | ||||||
---|---|---|---|---|---|---|---|---|
|
@@ -121,7 +121,7 @@ elif [ "${OS_ID_LIKE}" == "rhel" ]; then | |||||||
echo "tsflags=nodocs" >> /etc/dnf/dnf.conf | ||||||||
dnf -y upgrade | ||||||||
EPEL=epel-release | ||||||||
if [ "${AUDITWHEEL_ARCH}" == "i686" ]; then | ||||||||
if [ "${AUDITWHEEL_ARCH}" == "i686" ] || [ "${AUDITWHEEL_ARCH}" == "riscv64" ]; then | ||||||||
EPEL= | ||||||||
fi | ||||||||
dnf -y install dnf-plugins-core ${EPEL} | ||||||||
|
@@ -130,7 +130,13 @@ elif [ "${OS_ID_LIKE}" == "rhel" ]; then | |||||||
else | ||||||||
dnf config-manager --set-enabled crb | ||||||||
fi | ||||||||
TOOLCHAIN_DEPS=(gcc-toolset-14-binutils gcc-toolset-14-gcc gcc-toolset-14-gcc-c++ gcc-toolset-14-gcc-gfortran gcc-toolset-14-libatomic-devel) | ||||||||
if [ "${AUDITWHEEL_POLICY}" == "manylinux_2_28" ] || [ "${AUDITWHEEL_POLICY}" == "manylinux_2_34" ]; then | ||||||||
TOOLCHAIN_DEPS=(gcc-toolset-14-binutils gcc-toolset-14-gcc gcc-toolset-14-gcc-c++ gcc-toolset-14-gcc-gfortran gcc-toolset-14-libatomic-devel) | ||||||||
else | ||||||||
# TODO enable gcc-toolset-15 once available (probably in 10.1) | ||||||||
# TOOLCHAIN_DEPS=(gcc-toolset-15-binutils gcc-toolset-15-gcc gcc-toolset-15-gcc-c++ gcc-toolset-15-gcc-gfortran gcc-toolset-15-libatomic-devel) | ||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. [nitpick] Similar to the build.sh file, there's a commented-out gcc-toolset-15 configuration. Consider removing this commented line or adding documentation explaining its purpose.
Suggested change
Copilot uses AI. Check for mistakes. Positive FeedbackNegative Feedback |
||||||||
TOOLCHAIN_DEPS=(binutils gcc gcc-c++ gcc-gfortran libatomic) | ||||||||
fi | ||||||||
if [ "${AUDITWHEEL_ARCH}" == "x86_64" ]; then | ||||||||
TOOLCHAIN_DEPS+=(yasm) | ||||||||
fi | ||||||||
|
Uh oh!
There was an error while loading. Please reload this page.