-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Restore License Classifier #4957
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Assuming this is all correct, I'd very much appreciate a release with the hopes of resolving any license issues from users who depend on enterprise tools that check for license declarations. |
I tested this by doing |
Partially reverts pypa@4e1e893
@jaraco This is a very big problem for enterprise environments that use tools to prevent unlicensed software from being used. It would mean a lot if you could restore the old license declaration before making additional releases. |
We are also adding setuptools to allowed package in license scanner just to make sure our pipelines pass Do you know the process here? Approved does not mean it is merged, or can you now merge it? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for fixing this
This setting is maintained at the skeleton level and probably shouldn't be customized here for Setuptools. There's nothing unique to Setuptools. I appreciate the PR, but I'd prefer to resolve the issue at the system level (skeleton in this case) or at least resolve the concerns and not simply revert an intentional change. |
Summary of changes
Partially reverts
4e1e893
Which removed all license declarations from the project without adding a proper SPDX identifier.
#4901 has a discussion on what the new license declaration should be, but until that's resolved, this restores the old license declaration so that automated tools do not reject setuptools as having no license.
Closes #4956
Pull Request Checklist
newsfragments/
.(See documentation for details)