Preserve dynamic metadata for empty dependencies#5242
Open
lin-hongkuan wants to merge 1 commit into
Open
Conversation
Contributor
|
Tick the box to add this pull request to the merge queue (same as
|
8ddz2ypcv7-create
approved these changes
Jun 25, 2026
8ddz2ypcv7-create
left a comment
There was a problem hiding this comment.
Tick the box to add this pull request to the merge queue (same as @Mergifyio queue).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
Preserve dynamic core metadata for dependencies when
project.dynamic = ['dependencies']is supplied and the resolved dependency list is empty.Setuptools already marked non-empty dynamic dependency lists as
Dynamic: requires-distbecause those lists are non-static values. Empty lists were skipped by the metadata writer's truthiness check, so an explicitinstall_requires=[]fromsetup.pyproduced noDynamicfield. This change records the corresponding core metadata field while applyingpyproject.tomldynamic metadata, allowing empty dynamic dependency lists to stay dynamic without marking staticdependencies = []as dynamic.Closes #5120
Pull Request Checklist
newsfragments/.(See documentation for details)
Tests
python -m pytest -q setuptools/tests/config/test_apply_pyprojecttoml.py setuptools/tests/config/test_pyprojecttoml_dynamic_deps.py setuptools/tests/test_core_metadata.pypython -m ruff check setuptools/_core_metadata.py setuptools/config/_apply_pyprojecttoml.py setuptools/tests/config/test_apply_pyprojecttoml.pypython -m ruff format --check setuptools/_core_metadata.py setuptools/config/_apply_pyprojecttoml.py setuptools/tests/config/test_apply_pyprojecttoml.pypython -m mypy setuptools/_core_metadata.py setuptools/config/_apply_pyprojecttoml.pygit diff --check