-
Notifications
You must be signed in to change notification settings - Fork 68
Adding metrics to strokes made by COINS #704
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
csebastiao
wants to merge
29
commits into
pysal:main
Choose a base branch
from
anastassiavybornova:stroke-graph
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/momepy into stroke-graph
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #704 +/- ##
=======================================
+ Coverage 97.4% 97.4% +0.1%
=======================================
Files 26 42 +16
Lines 4328 7275 +2947
=======================================
+ Hits 4214 7088 +2874
- Misses 114 187 +73
🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #591 for explanation. Drafted without full tests and documentation. We ran the code with https://github.com/pysal/momepy/blob/main/ci/envs/312-latest.yaml.
Contribution
Adding a
strokegraph.py
file with 2 main functions:strokes_to_graph
takingmomepy.COINS
as an input and returning a dual graph where each node is a stroke inmomepy.COINS
and each edge is when two strokes are intersecting. Optional arguments include computing additional metrics on the strokes (degree, closeness, betweenness, connectivity, access, orthogonality, and spacing, see (El Gouj et al., 2022) for details), and returning the primal graph of the street network with the information about each stroke on every edge composing them.graph_to_strokes
taking the dual graph generated bystrokes_to_graph
as an input and returning amomepy.COINS
object as an output.Questions
graph_to_strokes
, as it returns the output frommomepy.COINS
?strokes_to_graph
where the return of the primal graph is optional make sense ?TODOs