Added a storage utility #105
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntoll
approved these changes
Jun 18, 2024
| <script type="micropython" async> | ||
| from polyscript import storage | ||
|
|
||
| map = await storage("@polyscript/storage") |
There was a problem hiding this comment.
Perhaps rename map to store..? To my ears it sounds more natural. Feel free to ignore.
There was a problem hiding this comment.
it's just an example ... you can name it s if you prefer ... I don't mind, though it's literally an instanceof Map https://github.com/pyscript/polyscript/pull/105/files#diff-a497e59c79570ea211b04920b54c45dd1b0a3bcedf9d788222891334008a1c00
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This MR exposes yet another handy utility behind the
storagename.It allows users to initiate a persistent IndexedDB based Map that will act synchronously after initialization.
/cc @ntoll