Skip to content

Organised downloads#1700

Closed
ikanop wants to merge 8 commits into
pystardust:masterfrom
ikanop:organised-downloads
Closed

Organised downloads#1700
ikanop wants to merge 8 commits into
pystardust:masterfrom
ikanop:organised-downloads

Conversation

@ikanop

@ikanop ikanop commented Apr 29, 2026 •
edited
Loading

Copy link
Copy Markdown

Pull Request Template

Type of change

  • Bug fix
  • Feature
  • Documentation update

Description

ramble here

Checklist

  • any anime playing
  • bumped version
  • next, prev and replay work
  • -c history and continue work
  • -s syncplay works
  • -d downloads work
  • -q quality works
  • -v vlc works
  • -e (select episode) aka -r (range selection) works
  • -S select index works
  • --skip ani-skip works
  • --skip-title ani-skip title argument works
  • --no-detach no detach works
  • --exit-after-play auto exit after playing works
  • --nextep-countdown countdown to next ep works
  • --dub and regular (sub) mode both work
  • all providers return links (not necessarily on a single anime, use debug mode to confirm)
  • -h help info is up to date
  • Readme is up to date
  • Man page is up to date

Additional Testcases

  • The safe bet: One Piece
  • Episode 0: Saenai Heroine no Sodatekata ♭
  • Unicode: Saenai Heroine no Sodatekata ♭
  • Non-whole episodes: Tensei shitara slime datta ken (ep. 24.5, ep. 24.9)
  • All Providers: Youkoso Jitsuryoku Shijou Shugi no Kyoushitsu e (TV) (3 m3u8, 3 mp4, 1 fast4speed, 1 sharepoint)
  • The examples of the help text

justchokingaround and others added 7 commits April 22, 2026 18:09
@justchokingaround
fix: update allanime key and ct_len
e5523a9 
The Allanime API changed encryption on 2026-04-22.
- Base key: SimtVuagFbGR2K7P -> Xot36i3lK3:v1
  (now includes ":v1" suffix, derived via SHA-256)
- Blob format: [version:1][IV:12][ciphertext][auth_tag:16]
  (was: [IV:12][plaintext] — version byte was skipped)
- Ciphertext length: explicit ct_len = file_size - 13 - 16
  (was: read entire rest, including GCM auth tag)
- Version bump: 4.12.0 -> 4.13.0
@justchokingaround
chore: shellcheck
9678215
@justchokingaround
feat: add filemoon provider
156bf9b
@justchokingaround
fix: update api_resp req including query_hash and origin
1ccbf71
@justchokingaround
Merge branch 'master' into allanime-fix
4ed6001
@justchokingaround
style: apply shfmt formatting
3620be5
@justchokingaround
fix: correct pattern expansion and add shellcheck disable
9b46d31
@ikanop ikanop requested a review from Derisis13 as a code owner April 29, 2026 08:05
port19x
port19x requested changes May 6, 2026
View reviewed changes

@port19x port19x left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have different formatter settings. Please don't re-indent the whole file

@ikanop

ikanop commented May 6, 2026

Copy link
Copy Markdown
Author

You have different formatter settings. Please don't re-indent the whole file

oh yes, sorry. Could i get the formatting settings please, and then i will reformat it to correct?

@port19x

port19x commented May 6, 2026

Copy link
Copy Markdown
Collaborator

Yes, it is shfmt -i 4 -ci -d

@ikanop ikanop force-pushed the organised-downloads branch from 3d5abba to 9415864 Compare May 6, 2026 07:20
@port19x

port19x commented May 6, 2026

Copy link
Copy Markdown
Collaborator

Something went wrong in your git workflow here.
This looks like you're re-committing our head commit.
I suggest you close this one and start over from a clean fork and open another PR.
Sorry about that.

@ikanop

ikanop commented May 6, 2026

Copy link
Copy Markdown
Author

Something went wrong in your git workflow here. This looks like you're re-committing our head commit. I suggest you close this one and start over from a clean fork and open another PR. Sorry about that.

? i think i fixed it? the diff shows only my change on my commit and the other commits is just a fork that i pulled into my fork

@port19x

port19x commented May 6, 2026

Copy link
Copy Markdown
Collaborator

Exactly, besides merge conflicts, this PR looks like choky did 7 commits and then you did something too.
This makes review harder and conflict resolution is non-trivial.
If you pulled in the choky PR prior to merge that makes it even worse

@port19x

port19x commented May 6, 2026

Copy link
Copy Markdown
Collaborator

If your intended PR is just this one line change breaking one of our features and changing defaults, you can save us both some time and just close the PR:
image

@ikanop

ikanop commented May 6, 2026

Copy link
Copy Markdown
Author

Exactly, besides merge conflicts, this PR looks like choky did 7 commits and then you did something too. This makes review harder and conflict resolution is non-trivial. If you pulled in the choky PR prior to merge that makes it even worse

oh okay, i will make a new PR

@port19x port19x closed this May 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@port19x port19x port19x requested changes
@Derisis13 Derisis13 Awaiting requested review from Derisis13 Derisis13 is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ikanop @port19x @justchokingaround