Skip to content

fix: forward skip_flag to syncplay player invocation - #1872

Open
TheMridul wants to merge 4 commits into
pystardust:masterfrom
TheMridul:fix-syncplay-skip-flag
Open

fix: forward skip_flag to syncplay player invocation#1872
TheMridul wants to merge 4 commits into
pystardust:masterfrom
TheMridul:fix-syncplay-skip-flag

Conversation

@TheMridul

Copy link
Copy Markdown

Summary

  • --skip computes skip_flag via ani-skip and forwards it to the *mpv* and *flatpak*mpv* player branches in play_episode(), but the *yncpla* (syncplay) branch never included it, so combining -s/--syncplay with --skip silently did nothing.
  • Adds $skip_flag to the syncplay invocation's player-args passthrough (after --), matching the other mpv-based branches.

Test plan

  • Ran ani-cli -s --skip "<anime>" with ani-skip installed and confirmed intro is skipped when launched via syncplay.
  • Confirmed plain ani-cli --skip "<anime>" (no syncplay) still skips intros as before.

--skip generates a skip_flag (from ani-skip) that was already being
passed to the mpv and flatpak-mpv player branches, but the syncplay
branch never forwarded it, so intro-skipping silently did nothing
when using -s/--syncplay together with --skip.
@port19x

port19x commented Aug 23, 2026

Copy link
Copy Markdown
Collaborator

I'm very interested in this change.
If you used AI in making this, which I don't want to accuse you of, but from the text it sounds a little like it, please add the used AI as a coauthor

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_011Q6f47MBpXqeffupBwpWjf
@TheMridul

Copy link
Copy Markdown
Author

Bumped to 5.0.3 — thanks for catching that, I missed it in CONTRIBUTING.

On the AI question, fair to ask. The bug and the fix are mine: I hit it running -s together with --skip, noticed intro-skipping silently did nothing, and traced it to the syncplay branch being the only player branch that never forwarded $skip_flag. The one-line change is hand-written.

What I did put through an AI was the PR description, which is almost certainly what you picked up on. The version bump commit I just pushed was also AI-written, so that one carries a Co-Authored-By trailer. Happy to squash it into the fix or restructure the commits however you prefer.

Copilot AI lite review requested due to automatic review settings September 5, 2026 12:44

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review is ineligible. To be eligible to request a review, you need a paid Copilot license, or your organization must enable Copilot code review.

@port19x

port19x commented Sep 5, 2026

Copy link
Copy Markdown
Collaborator

eyo wtf is copilot doing here??

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants