Subclassing the bool from long instead int object. #1424
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmod
reviewed
Jul 8, 2017
src/runtime/types.cpp
Outdated
| bool_cls->tp_mro = BoxedTuple::create({ bool_cls, int_cls, object_cls }); | ||
| complex_cls->tp_mro = BoxedTuple::create({ complex_cls, object_cls }); | ||
| long_cls->tp_mro = BoxedTuple::create({ long_cls, object_cls }); | ||
| bool_cls->tp_mro = BoxedTuple::create({ bool_cls, int_cls, object_cls }); |
There was a problem hiding this comment.
You'll need to update this to be long_cls instead of int_cls.
|
Looks awesome! Let's get a small test file set up, something like this: long_ = type(1L)
assert isinstance(True, long_)
assert issubclass(bool, long_)
print(bool.__bases__) |
In Python 2, the bool object just a int object. In Python 3, the bool object become long object. So change the bool object to the subclass of long object, prepare for other Python 3 updates.
If any tests ready to python 3, we need to add 'py3ready' flag in the beginning of the file
cmake 2 can not build target Ninja.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Python 2, the bool object is essentially an int object. In Python 3, it is long object. This PR subclass the bool object from long instead of the int. Preparing for removing the int object completely.