Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PythonNode when used as return. #446

Merged
merged 7 commits into from
Oct 11, 2023
Merged

Fix PythonNode when used as return. #446

merged 7 commits into from
Oct 11, 2023

Conversation

tobiasraabe
Copy link
Member

@tobiasraabe tobiasraabe commented Oct 10, 2023

No description provided.

@codecov
Copy link

codecov bot commented Oct 10, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (7b6f184) 95.00% compared to head (55458d3) 95.00%.

❗ Current head 55458d3 differs from pull request most recent head a1a8e54. Consider uploading reports for the commit a1a8e54 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #446   +/-   ##
=======================================
  Coverage   95.00%   95.00%           
=======================================
  Files          97       97           
  Lines        8521     8529    +8     
=======================================
+ Hits         8095     8103    +8     
  Misses        426      426           
Flag Coverage Δ
end_to_end 82.08% <91.30%> (+0.01%) ⬆️
integration 39.37% <45.65%> (+0.10%) ⬆️
unit 65.89% <82.60%> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/_pytask/collect.py 92.45% <100.00%> (-0.25%) ⬇️
src/_pytask/collect_utils.py 96.17% <100.00%> (+0.19%) ⬆️
src/_pytask/dag.py 100.00% <100.00%> (ø)
src/_pytask/path.py 98.36% <ø> (-0.08%) ⬇️
src/_pytask/typing.py 100.00% <100.00%> (ø)
tests/test_execute.py 99.02% <ø> (-0.02%) ⬇️
src/_pytask/nodes.py 86.13% <91.66%> (+0.72%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tobiasraabe tobiasraabe added this to the v0.4.1 milestone Oct 10, 2023
@tobiasraabe tobiasraabe merged commit 0fceb2a into main Oct 11, 2023
@tobiasraabe tobiasraabe deleted the fix-pythonnode branch October 11, 2023 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant