Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix type hints for Task.execute() and TaskWithoutPath.execute(). #548

Merged
merged 2 commits into from
Jan 11, 2024

Conversation

tobiasraabe
Copy link
Member

@tobiasraabe tobiasraabe commented Jan 11, 2024

Related to #547.

@tobiasraabe tobiasraabe added this to the v0.4.6 milestone Jan 11, 2024
@tobiasraabe tobiasraabe changed the title Fix type hints for PTask.execute(). Fix type hints for PTask.execute(). Jan 11, 2024
Copy link

codecov bot commented Jan 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c7f3da8) 97.83% compared to head (cfeb91d) 97.83%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #548   +/-   ##
=======================================
  Coverage   97.83%   97.83%           
=======================================
  Files         106      106           
  Lines        8976     8976           
=======================================
  Hits         8782     8782           
  Misses        194      194           
Flag Coverage Δ
end_to_end 82.67% <100.00%> (-0.02%) ⬇️
integration 40.70% <100.00%> (ø)
unit 69.22% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Co-authored-by: Mathijs Verhaegh <[email protected]>
@tobiasraabe tobiasraabe changed the title Fix type hints for PTask.execute(). Fix type hints for Task.execute() and TaskWithoutPath.execute(). Jan 11, 2024
@tobiasraabe tobiasraabe enabled auto-merge (squash) January 11, 2024 15:54
@tobiasraabe tobiasraabe merged commit 0a767f1 into main Jan 11, 2024
@tobiasraabe tobiasraabe deleted the fix-task-execute-type-hints branch January 11, 2024 15:59
@tobiasraabe tobiasraabe modified the milestones: v0.4.6, v0.5.0 Jan 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant