refactor: implement legacy hookwrappers in terms of a modern hook" #546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RonnyPfannschmidt
force-pushed
the
ronny/hookwrapper-wrap-legacy
branch
from
cc5ef1d to
d249bd5
Compare
|
@nicoddemus ping - can you take a look |
|
failures unrelated as pytest dropped python3.8 on main |
RonnyPfannschmidt
force-pushed
the
ronny/hookwrapper-wrap-legacy
branch
2 times, most recently
from
ae3572d to
a3c8d56
Compare
nicoddemus
approved these changes
Jan 12, 2025
src/pluggy/_callers.py
Outdated
| Teardown = Generator[None, object, object] | ||
|
|
||
|
|
||
| def run_legacy_hookwrapper( |
There was a problem hiding this comment.
We call this "old-style" in the docs, perhaps:
Suggested change
| def run_legacy_hookwrapper( | |
| def run_old_style_hookwrapper( |
RonnyPfannschmidt
force-pushed
the
ronny/hookwrapper-wrap-legacy
branch
2 times, most recently
from
9376cb5 to
903653c
Compare
|
@nicoddemus the coverage seems bogous |
Raising a StopIteration in a generator triggers a RuntimeError. If the RuntimeError of a generator has the passed in StopIteration as cause resume with that StopIteration as normal exception instead of failing with the RuntimeError.
RonnyPfannschmidt
force-pushed
the
ronny/hookwrapper-wrap-legacy
branch
from
903653c to
25af101
Compare
RonnyPfannschmidt
force-pushed
the
ronny/hookwrapper-wrap-legacy
branch
from
a4e03dc to
d0ab361
Compare
RonnyPfannschmidt
force-pushed
the
ronny/hookwrapper-wrap-legacy
branch
from
16114aa to
d443764
Compare
|
@nicoddemus i took a rather brutal approach to coverage - please have another look |
|
@nicoddemus gentle ping |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
followup to #545
moves the implementation of legacy hooks into a new style hook