Remove use of deprecated function from test synchronizer #1203
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…om synchronizer to test item. This allows getting rid of _get_event_loop_no_warn.
|
Degrading this PR to draft state, because the changes cause a warning to be emitted twice. |
This fixes a bug that lead to multiple deprecation warnings being emitted.
This should speed up the test suite and give more accurate test coverage numbers.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1203 +/- ##
==========================================
+ Coverage 88.91% 90.81% +1.90%
==========================================
Files 2 2
Lines 406 403 -3
Branches 44 43 -1
==========================================
+ Hits 361 366 +5
+ Misses 35 29 -6
+ Partials 10 8 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
seifertm
deleted the
remove-use-of-deprecated-get-event-loop-from-test-synchronizer
branch
seifertm
restored the
remove-use-of-deprecated-get-event-loop-from-test-synchronizer
branch
seifertm
deleted the
remove-use-of-deprecated-get-event-loop-from-test-synchronizer
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The function wrap_in_sync makes use of of
_get_event_loop_no_warnwhich uses deprecated asyncio functionality.This PR removes the use of
_get_event_loop_no_warninsidewrap_in_syncby hoisting the decision logic for determining the current event loop one level higher.PytestAsyncTestnow determines the applicable runner fixture and passes it to wrap_in_sync.Lastly, the PR renames
wrap_in_syncto_synchronize_coroutine.