Skip to content

feat: reset worker after file #1254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

feat: reset worker after file #1254

wants to merge 1 commit into from

Conversation

JuroOravec
Copy link

This is a proof of concept for #363

@JuroOravec JuroOravec mentioned this pull request Oct 5, 2025
Open
RonnyPfannschmidt
RonnyPfannschmidt requested changes Oct 5, 2025
View reviewed changes
Copy link
Member

@RonnyPfannschmidt RonnyPfannschmidt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the key parts of making this work sane is - interaction with worker restart limits, limiting collection on subsequent test processes and correct shutdown of the nodes (no os._exit)

src/xdist/remote.py
if session.shouldfail or session.shouldstop:
break
if self.shutdown_on_finish:
os._exit(1)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

os.exit is always the wrong thing to do there

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@RonnyPfannschmidt RonnyPfannschmidt RonnyPfannschmidt requested changes

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@JuroOravec @RonnyPfannschmidt