-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Display output failure message in insertion order of dictionary #13587
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ritvi-alagusankar
wants to merge
13
commits into
pytest-dev:main
Choose a base branch
from
ritvi-alagusankar:fix-output-order-dictionary-keys
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+155
−14
Open
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
896c8b9
fix: display output failure message in insertion order of dictionary
ritvi-alagusankar 4468c17
chore: add changelog message
ritvi-alagusankar 62f5a34
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 12b4233
fix: test case
ritvi-alagusankar 0ce44bb
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 9205e51
test: fix test cases
ritvi-alagusankar bcaa184
test: add test case nested dicts
ritvi-alagusankar 57ecd50
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 0188efc
Merge branch 'main' into fix-output-order-dictionary-keys
ritvi-alagusankar f898fdd
style: fix fmt
ritvi-alagusankar 29689b2
Merge branch 'fix-output-order-dictionary-keys' of https://github.com…
ritvi-alagusankar 290e21f
test: add test case for pprint
ritvi-alagusankar 18c2548
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
Fixed the order of dictionary keys in assertion failure messages. | ||
Previously, dictionary diffs were shown in alphabetical order, regardless of how the keys appeared in the original dicts. | ||
Now, common keys are shown in the insertion order of the left-hand dictionary, | ||
and differing keys are shown in the insertion order of their respective dictionaries |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This has the caveats of not working for nesting
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added a test case for nested dictionaries, and it appears to be working as expected. The
extra_left
set only includes keys from the top level of the dictionary, so nested dicts shouldn't pose an issue. Let me know if this is the concern you were referring to.