Make it possible for faulthandler to terminate the pytest process on timeout #13679
+82
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psf-chronographer
bot
added
the
bot:chronographer:provided
RonnyPfannschmidt
approved these changes
Aug 27, 2025
|
I think I understand why the |
ogrisel
commented
Aug 27, 2025
ogrisel
commented
Aug 27, 2025
webknjaz
reviewed
Aug 28, 2025
Co-authored-by: 🇺🇦 Sviatoslav Sydorenko (Святослав Сидоренко) <[email protected]>
ogrisel
commented
Sep 3, 2025
| True, | ||
| marks=pytest.mark.skipif( | ||
| "CI" in os.environ, reason="sometimes crashes on CI (#7022)" | ||
| ), |
There was a problem hiding this comment.
I changed the skip mark to a conditional mark to make it easy to check that this test actually passes locally.
There was a problem hiding this comment.
I think I tried earlier, but this does not work because xfail_strict = true is configured in pyproject.toml and those tests would XPASS on most CI configurations except ubuntu-py314 that tends to fail for a reason I do not understand as investigated in #13695.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #13678.
This would help projects avoid wasting their precious CI resources when running extensive thread-safety tests (which will become more popular in the new free-threading era).
I also changed the logic to mark the test as XFAIL conditionally on the presence of the "CI" environment variable instead of always skipping (related to #7022). This makes it possible to check that the test pass as expected when running locally.
If you think this is too risky, I can remove the condition and always mark the offending params with the
xfailmark instead of skipping.EDIT: I will do the later right away because I have already observed such a random failure on the CI: https://github.com/pytest-dev/pytest/actions/runs/17269674978/job/49010727146
EDIT 2: that does not work because
xfail_strict = trueis configured inpyproject.toml. Let me skip instead...