Fix: Skip system temp directories in rootdir detection (issue #13822) #13826
+62
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dev#13822) - Add helper function _is_system_temp_or_parent() to detect system temp dir - Modify determine_setup() to skip /tmp when searching for setup.py - Prevents pytest from incorrectly using /tmp as rootdir when /tmp/setup.py exists Fixes pytest-dev#13822
for more information, see https://pre-commit.ci
nicoddemus
requested changes
Oct 19, 2025
There was a problem hiding this comment.
Thanks @AddyM,
Could you please add a test to ensure this does not regress? You can monkeypatch tempfile.gettempdir() to avoid adding files to the system's temporary directory.
- Test verifies that setup.py in system temp dir is ignored - Uses monkeypatch to simulate /tmp/setup.py without touching system - Ensures rootdir detection works correctly
…com/addym/pytest into fix/issue-13822-tmp-setup-detection
Hello @nicoddemus , thanks a lot for the input , added a regression test .Please help in reviewing . Thanks |
for more information, see https://pre-commit.ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #13822
When
/tmp/setup.pyexists on the system, pytest incorrectly identifies/tmpas the project root, causing test node IDs to include full paths under/tmpinstead of relative paths.Changes
_is_system_temp_or_parent()helper function to detect system temp directoriesdetermine_setup()to skip system temp directories when searching forsetup.pytempfile.gettempdir()for cross-platform compatibilityTesting
Backward Compatibility
--rootdirto override if needed