Fix rootdir detection when setup.py exists in temp directory #13828
+80
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13822
This PR addresses a bug where pytest incorrectly identifies the system temp directory as the project rootdir when a
setup.pyfile exists in/tmp(or the system temp directory).Problem
When a
setup.pyfile exists in the temp directory (e.g.,/tmp/setup.py), pytest's rootdir detection logic would walk up the directory tree and find this file, incorrectly setting/tmpas the rootdir. This caused test nodeids to include the full temporary path instead of just the filename, breaking thetest_warning_recorded_hooktest and potentially affecting other functionality.Solution
The fix modifies the
determine_setupfunction insrc/_pytest/config/findpaths.pyto skipsetup.pyfiles specifically located in the directory returned bytempfile.gettempdir(). This prevents the temp directory from being mistakenly identified as a project root while preserving normal setup.py detection for legitimate project directories.Changes
Testing
The fix has been validated with:
/tmp/setup.pypresenttest_warning_recorded_hooktestThis is a targeted fix that specifically addresses the temp directory edge case without affecting other pytest functionality.