Update docs for Entropy v2 #748
Merged
+78
−118
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Fixed the prettier in c9a4feb, unrelated to this PR though. I like to see build passing. |
jayantk
approved these changes
Jul 17, 2025
| @@ -200,3 +161,20 @@ Check the [Current Fees](../current-fees) to find the current fee for each provi | |||
| ### Best Practices | |||
|
|
|||
| Check out the [Best Practices](../best-practices) guide for tips to limit gas usage, or generate multiple random numbers in a single transaction. | |||
|
|
|||
| <Callout type="info"> | |||
There was a problem hiding this comment.
I think the callout here needs some wordsmithing because you don't always need to select a provider. Probably something like "Some methods on Entropy require selecting..."
| who participates in the generation process. Each provider is identified by an address and hosts | ||
| a keeper service for fullfilling requests. | ||
|
|
||
| The simplest way to choose a provider is to use the [default provider](../contract-addresses). |
There was a problem hiding this comment.
and the best way to get this is to call the getDefaultProvider() method on the contract. It's much better to use the method than hardcode the address (what if we change the provider??)
|
|
||
| The fees differs for every chain and can be found at the [Current Fees](../current-fees) page. \ | ||
| You can use the onchain method [`getFee`](https://github.com/pyth-network/pyth-crosschain/blob/main/target_chains/ethereum/entropy_sdk/solidity/IEntropy.sol#L101) to calculate the fee for the default provider and send it as the value of the `requestWithCallback` call: | ||
| The fees differs for every chain and also varies over time depending on the chain's current gas price. |
aditya520
reviewed
Jul 17, 2025
| function requestRandomNumber(bytes32 userRandomNumber) external payable { | ||
| uint256 fee = entropy.getFee(entropyProvider); | ||
| function requestRandomNumber() external payable { | ||
| uint256 fee = entropy.getFeeV2(); |
There was a problem hiding this comment.
Shouldn't we mention that getFeeV2() will use DefaultProvider?
aditya520
approved these changes
Jul 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update docs for Entropy v2
Type of Change
Checklist
pre-commit run --all-filesto check for linting errors