Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: proper number parsing for chunking #2539

Merged

Conversation

bangjelkoski
Copy link
Contributor

Summary

We had to fix the arguments passing to the splitArrayToChunks to be a Number.

Rationale

How has this been tested?

  • [] Current tests cover my changes
  • Added new tests
  • Manually tested the code

@bangjelkoski bangjelkoski requested a review from a team as a code owner April 1, 2025 19:36
Copy link

vercel bot commented Apr 1, 2025

@bangjelkoski is attempting to deploy a commit to the Pyth Network Team on Vercel.

A member of the Team first needs to authorize it.

@bangjelkoski bangjelkoski marked this pull request as draft April 1, 2025 20:28
@bangjelkoski bangjelkoski marked this pull request as ready for review April 1, 2025 20:35
@bangjelkoski bangjelkoski marked this pull request as draft April 1, 2025 21:05
@bangjelkoski bangjelkoski marked this pull request as ready for review April 1, 2025 21:40
@bangjelkoski
Copy link
Contributor Author

bangjelkoski commented Apr 1, 2025

Tested locally against mainnet

{"hash":"95527DF7FA6A3B38BCA63E134ED748C857DE3E84D81D1E2EE497C7F84E3E76B0","msg":"Successfully broadcasted txHash for chunk 2"}
{"hash":"CFCD1A2FB8F141A35C1739D737EB66F0B3CA5ABD3DD67D602C8DBEA90AF01546","msg":"Successfully broadcasted txHash for chunk 3"}
{"hash":"EA901953FC16D7831D1BE29EF7E5E1C2C67A6D6D5855AA00D9DAF90346BC972D","msg":"Successfully broadcasted txHash for chunk 1"}
{"hash":"94FC58E91ECEA2D31608026FEE289A7BD74A294D00C23EBA9D650C1BF877CC7C","msg":"Successfully broadcasted txHash for chunk 0"}

Copy link
Collaborator

@ali-bahjati ali-bahjati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great changes here. My only concern here is the bookkeeping of accounts and their balances especially because you'll have more accounts as you add more feeds.

@bangjelkoski
Copy link
Contributor Author

We could add some logging so it's easier for tracking, what do you think? @ali-bahjati

@ali-bahjati ali-bahjati force-pushed the fix/arg-to-number-parsing branch from 97d4459 to 10122f0 Compare April 7, 2025 12:55
@ali-bahjati ali-bahjati merged commit 62039cf into pyth-network:main Apr 7, 2025
2 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants