Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(insights): publisher table improvements #2548

Merged
merged 1 commit into from
Apr 2, 2025

Conversation

cprussin
Copy link
Collaborator

@cprussin cprussin commented Apr 2, 2025

Summary

  • Add ranking explanation
  • Remove inactive feeds column
  • Change name of permissioned feeds column from "FEEDS" to "PERMISSIONED"

Rationale

Feedback from @ndiakom

How has this been tested?

  • Current tests cover my changes
  • Added new tests
  • Manually tested the code

@cprussin cprussin requested a review from a team as a code owner April 2, 2025 21:03
Copy link

vercel bot commented Apr 2, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
insights ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 2, 2025 9:14pm
5 Skipped Deployments
Name Status Preview Comments Updated (UTC)
api-reference ⬜️ Ignored (Inspect) Visit Preview Apr 2, 2025 9:14pm
component-library ⬜️ Ignored (Inspect) Visit Preview Apr 2, 2025 9:14pm
entropy-debugger ⬜️ Ignored (Inspect) Visit Preview Apr 2, 2025 9:14pm
proposals ⬜️ Ignored (Inspect) Visit Preview Apr 2, 2025 9:14pm
staking ⬜️ Ignored (Inspect) Visit Preview Apr 2, 2025 9:14pm

@ndiakom
Copy link
Contributor

ndiakom commented Apr 2, 2025

Typo "numebr" on line 15 in apps/insights/src/components/Explanations/index.tsx
@cprussin

- Add ranking explanation
- Remove inactive feeds column
- Change name of permissioned feeds column from "FEEDS" to "PERMISSIONED"
@cprussin cprussin force-pushed the cprussin/publisher-table-improvements branch from 1097a80 to e9ef828 Compare April 2, 2025 21:09
@cprussin cprussin merged commit a1ad7f3 into main Apr 2, 2025
9 checks passed
@cprussin cprussin deleted the cprussin/publisher-table-improvements branch April 2, 2025 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants