refactor(pythnet/pythnet_sdk): add test for update data with fixture #2551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this is a good test but also a good tool to deserialize update data for troubleshooting.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 6 Skipped Deployments
|
darunrs
approved these changes
Apr 3, 2025
| let update = hex::decode(update).unwrap(); | ||
| let update = AccumulatorUpdateData::try_from_slice(&update).unwrap(); | ||
| let Proof::WormholeMerkle { vaa: _, updates } = update.proof; | ||
| println!("Updates: {:?}", updates.len()); |
There was a problem hiding this comment.
Did you want to keep these prints in? Should they be assertions instead?
There was a problem hiding this comment.
The assertion is mostly the unwrap part. I kept the prints for debugging the contents.
tejasbadadare
approved these changes
Apr 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
add test for update data with fixture
Rationale
This is a good test but also a good tool to deserialize update data for troubleshooting. If we get many requests to parse the update data we can add it as an API to Hermes or make a CLI for it but I don't think it's necessary for now.
How has this been tested?