feat: use sendTransaction for OIS #2555
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
4 Skipped Deployments
|
cprussin
approved these changes
Apr 3, 2025
guibescos
reviewed
Apr 4, 2025
| wallet: { | ||
| publicKey: wallet.publicKey, | ||
| signAllTransactions: wallet.signAllTransactions, | ||
| signTransaction: wallet.signTransaction, |
There was a problem hiding this comment.
signTransaction and signAllTransactions are not used anymore?
There was a problem hiding this comment.
Yes they are not used afaik, but I thought it's better to keep them.
guibescos
reviewed
Apr 4, 2025
|
|
||
| return sendTransactions(transactions, connection, wallet); | ||
| for (const transaction of transactions) { | ||
| await wallet.sendTransaction(transaction.tx, connection); |
There was a problem hiding this comment.
remind me why the interface needs a connection?
There was a problem hiding this comment.
not sure tbh, my guess is that some wallets will use this connection to send the tx instead of their own.
guibescos
approved these changes
Apr 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Use wallet send transaction for OIS instead of sign and send
Rationale
For multisig wallets it takes time for everyone to sign and causes block hash to expire.
How has this been tested?