Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(staking): improve tester app feedback #2556

Merged
merged 2 commits into from
Apr 3, 2025
Merged

Conversation

cprussin
Copy link
Collaborator

@cprussin cprussin commented Apr 3, 2025

Summary

Adds better feedback when testing wallets

Rationale

Currently the feedback only feels nice if your wallet pops up, but e.g. if you use walletconnect you don't get a popup so the app looks like it isn't doing anything after you click "test"

How has this been tested?

  • Current tests cover my changes
  • Added new tests
  • Manually tested the code

@cprussin cprussin requested a review from a team as a code owner April 3, 2025 22:51
Copy link

vercel bot commented Apr 3, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
staking ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 3, 2025 10:53pm
5 Skipped Deployments
Name Status Preview Comments Updated (UTC)
api-reference ⬜️ Ignored (Inspect) Visit Preview Apr 3, 2025 10:53pm
component-library ⬜️ Ignored (Inspect) Apr 3, 2025 10:53pm
entropy-debugger ⬜️ Ignored (Inspect) Apr 3, 2025 10:53pm
insights ⬜️ Ignored (Inspect) Visit Preview Apr 3, 2025 10:53pm
proposals ⬜️ Ignored (Inspect) Apr 3, 2025 10:53pm

@cprussin cprussin merged commit cd44d2b into main Apr 3, 2025
8 of 9 checks passed
@cprussin cprussin deleted the cprussin/remove-logging branch April 3, 2025 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants