fix(staking-sdk): fix staking-sdk build #2567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit makes the following related changes: - Fix `@pythnetwork/staking-sdk` build -- the prior build process created an unusable package due to producing invalid references in `package.json`. - Clean up `@pythnetwork/staking-sdk` typescript configs, using nodenext for the target and module resolution strategy - Fix import statements in `@pythnetwork/staking-sdk` to properly work with nodenext resolution - Distribute `@pythnetwork/staking-sdk` as esm-only -- nowadays supporting cjs is making less sense and in particular some of the underlying solana libs are distributed as esm-only, so it really doesn't make sense for us to distribute cjs - Stop using nextjs's `transpilePackages` for apps that depend on monorepo packages -- this makes less sense nowadays with [turbo watch](https://turbo.build/docs/reference/watch) and it has some major downsides, in particular it doesn't work if you have different tsconfig settings between apps and the packages they depend on.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
keyvankhademi
approved these changes
Apr 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit makes the following related changes:
@pythnetwork/staking-sdkbuild -- the prior build process created an unusable package due to producing invalid references inpackage.json.@pythnetwork/staking-sdktypescript configs, using nodenext for the target and module resolution strategy@pythnetwork/staking-sdkto properly work with nodenext resolution@pythnetwork/staking-sdkas esm-only -- nowadays supporting cjs is making less sense and in particular some of the underlying solana libs are distributed as esm-only, so it really doesn't make sense for us to distribute cjstranspilePackagesfor apps that depend on monorepo packages -- this makes less sense nowadays with turbo watch and it has some major downsides, in particular it doesn't work if you have different tsconfig settings between apps and the packages they depend on.