Skip to content

fix(staking-sdk): more staking-sdk improvements #2571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 9, 2025

Conversation

cprussin
Copy link
Collaborator

@cprussin cprussin commented Apr 9, 2025

Summary

Some more fixes / improvements to staking-sdk:

  • Don't disable eslint rules unnecessarily
  • Ensure we handle Uint8Arrays in the response body too
  • Throw an explicit error if we reach the end of the stream without finding a result

@cprussin cprussin requested a review from keyvankhademi April 9, 2025 05:50
@cprussin cprussin requested a review from a team as a code owner April 9, 2025 05:50
Copy link

vercel bot commented Apr 9, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
insights ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 9, 2025 6:03am
staking ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 9, 2025 6:03am
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
api-reference ⬜️ Ignored (Inspect) Visit Preview Apr 9, 2025 6:03am
component-library ⬜️ Ignored (Inspect) Visit Preview Apr 9, 2025 6:03am
entropy-debugger ⬜️ Ignored (Inspect) Visit Preview Apr 9, 2025 6:03am
proposals ⬜️ Ignored (Inspect) Visit Preview Apr 9, 2025 6:03am

- Don't disable eslint rules unnecessarily
- Ensure we handle `Uint8Array`s in the response body too
- Throw an explicit error if we reach the end of the stream without finding a result
@cprussin cprussin force-pushed the cprussin/more-staking-sdk-fixes branch from 05a8244 to a845328 Compare April 9, 2025 05:59
@cprussin cprussin merged commit 528e7d9 into main Apr 9, 2025
9 checks passed
@cprussin cprussin deleted the cprussin/more-staking-sdk-fixes branch April 9, 2025 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant