-
Notifications
You must be signed in to change notification settings - Fork 244
feat(target_chains/ethereum): add WithdrawFee action and implement related functionality in governance payload #2573
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
cctdaniel
wants to merge
6
commits into
main
Choose a base branch
from
withdraw-fees
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Skipped Deployments
|
0f47446
to
5dfec3f
Compare
Merged
3 tasks
ali-bahjati
reviewed
Apr 14, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is very nice. I made a comment to change the schema to be consistent; will approve after that.
target_chains/ethereum/contracts/contracts/pyth/PythGovernanceInstructions.sol
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Added support for the
WithdrawFee
governance action that allows withdrawing collected fees from Pyth contracts to a specified address. The changes include:WithdrawFee
action in governance payload systemxc_admin_common
Rationale
This feature is necessary to:
How has this been tested?
Current tests cover my changes
WithdrawFee
case to existing governance payload serialization testsWithdrawFee
to property-based testing viagovernanceActionArb
Added new tests
WithdrawFee
actionManually tested the code
The changes are well-tested through: