Skip to content

fix(apps/price_pusher): handle gas overrides properly #2669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 10, 2025

Conversation

ali-behjati
Copy link
Collaborator

@ali-behjati ali-behjati commented May 9, 2025

Summary

When we cannot land a transaction, in the error handling we return or throw the errors and it never sets the last tx attempt data that is a necessary data for gas overriding. This change fixes it by bringing up before the transaction push block.

This PR has a few other changes:

  • updates docs about confidence check

How has this been tested?

  • Current tests cover my changes
  • Added new tests
  • Manually tested the code

@ali-behjati ali-behjati requested a review from a team as a code owner May 9, 2025 11:57
Copy link

vercel bot commented May 9, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

8 Skipped Deployments
Name Status Preview Comments Updated (UTC)
api-reference ⬜️ Skipped (Inspect) Jun 10, 2025 11:57am
component-library ⬜️ Skipped (Inspect) Jun 10, 2025 11:57am
developer-hub ⬜️ Skipped (Inspect) Jun 10, 2025 11:57am
entropy-debugger ⬜️ Skipped (Inspect) Jun 10, 2025 11:57am
entropy-explorer ⬜️ Skipped (Inspect) Jun 10, 2025 11:57am
insights ⬜️ Skipped (Inspect) Jun 10, 2025 11:57am
proposals ⬜️ Skipped (Inspect) Jun 10, 2025 11:57am
staking ⬜️ Skipped (Inspect) Jun 10, 2025 11:57am

@ali-behjati ali-behjati force-pushed the price-pusher/fix-evm branch from 8ecb6d1 to b460407 Compare June 10, 2025 11:57
@vercel vercel bot temporarily deployed to Preview – entropy-debugger June 10, 2025 11:57 Inactive
@vercel vercel bot temporarily deployed to Preview – staking June 10, 2025 11:57 Inactive
@vercel vercel bot temporarily deployed to Preview – entropy-explorer June 10, 2025 11:57 Inactive
@vercel vercel bot temporarily deployed to Preview – developer-hub June 10, 2025 11:57 Inactive
@vercel vercel bot temporarily deployed to Preview – component-library June 10, 2025 11:57 Inactive
@vercel vercel bot temporarily deployed to Preview – proposals June 10, 2025 11:57 Inactive
@vercel vercel bot temporarily deployed to Preview – api-reference June 10, 2025 11:57 Inactive
@vercel vercel bot temporarily deployed to Preview – insights June 10, 2025 11:57 Inactive
@ali-behjati ali-behjati merged commit 5e356f4 into main Jun 10, 2025
12 checks passed
@ali-behjati ali-behjati deleted the price-pusher/fix-evm branch June 10, 2025 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants