feat(lazer/js/sdk): QSP auth for browser support #3014
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
5 Skipped Deployments
|
| if (isBrowser()) { | ||
| // Browser: Add token as query parameter | ||
| const urlObj = new URL(url); | ||
| urlObj.searchParams.set("ACCESS_TOKEN", token); |
There was a problem hiding this comment.
If this is available as a query param, why use bearer auth at all? Seems like if you have to support query param auth it's simpler to just always use the query param and never set the header...
There was a problem hiding this comment.
Yeahh, considered that, but we prefer people use the header whenever possible to avoid leaking the token in logs/some nginx somewhere/etc.
| function addAuthentication( | ||
| url: string, | ||
| token: string, | ||
| wsOptions: any = {} |
There was a problem hiding this comment.
In general you shouldn't ever use any; here you should type this correctly to match the types that are valid as options here. If you must, you can use unknown, but I don't think that makes sense in this case.
tejasbadadare
requested review from
ali-behjati and
keyvankhademi
as code owners
|
A twist here is that the The Thus, the SDK would only work in the browser if subscribing to messages with I'm going to park this PR for now since browser support isn't a highly requested feature and it could be a bit of a rabbit hole to address all inconsistencies between Node and browser. cc @ali-behjati @cprussin . |
Summary
Rationale
How has this been tested?