-
Notifications
You must be signed in to change notification settings - Fork 288
chore(developer-hub): Add Home page #3038
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for GitHub.
5 Skipped Deployments
|
<div | ||
className={[styles.productBadge, styles.lazerBadge].join( | ||
" ", | ||
)} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<section className={styles.quickStartSection}> | ||
<h2 className={styles.sectionHeading}>Quick Start</h2> | ||
<p className={styles.sectionDescription}> | ||
Get started with Pyth Network by exploring our comprehensive | ||
documentation: | ||
</p> | ||
<ul className={styles.quickStartList}> | ||
<li> | ||
<strong> | ||
<Link | ||
href="/pyth-core/getting-started" | ||
className={styles.link} | ||
> | ||
Price Feeds Getting Started | ||
</Link> | ||
</strong>{" "} | ||
- Integrate real-time price data | ||
</li> | ||
<li> | ||
<strong> | ||
<Link href="/lazer" className={styles.link}> | ||
Lazer Documentation | ||
</Link> | ||
</strong>{" "} | ||
- High-performance price feeds | ||
</li> | ||
<li> | ||
<strong> | ||
<Link href="/express-relay" className={styles.link}> | ||
Express Relay Integration | ||
</Link> | ||
</strong>{" "} | ||
- Better orderflow mechanism to eliminate MEV | ||
</li> | ||
<li> | ||
<strong> | ||
<Link href="/entropy" className={styles.link}> | ||
Entropy Implementation | ||
</Link> | ||
</strong>{" "} | ||
- Secure randomness generation | ||
</li> | ||
</ul> | ||
</section> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the same structure is basically used multiples times, maybe extract it into a separate component and just reuse the component?
eg:
type ProductCardProps = {
badge: string;
badgeClass: string;
icon: ReactNode;
title: string;
description: string;
features: { icon: ReactNode; text: string }[];
link: string;
cta: string;
};
const ProductCard = ({
badge,
badgeClass,
icon,
title,
description,
features,
link,
cta,
}: ProductCardProps) => (
<div className={styles.productCard}>
.....
<h3 className={styles.sectionTitle}>Additional Information</h3> | ||
<ul className={styles.navList}> | ||
<li> | ||
<Link href="/pyth-token" className={styles.navItem}> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you're prob aware, but these links are broken
|
||
@media (width <= 1024px) { | ||
max-width: 100%; | ||
padding: theme.spacing(6) theme.spacing(4); | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you use the breakpoints mixin, eg: https://github.com/pyth-network/pyth-crosschain/blob/main/apps/entropy-explorer/src/components/Home/results.module.scss
this is the source: https://github.com/pyth-network/pyth-crosschain/blob/main/packages/component-library/src/theme.scss#L898-L902
.productTitle { | ||
@include theme.text("lg", "semibold"); | ||
|
||
color: theme.color("heading"); | ||
margin-bottom: theme.spacing(3); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would also include the @include theme.h3;
and for the other semantic elements
As discussed with @aditya520, moving it to draft as there will be a new home page design and navigation may change as well. |
Summary
Add Home Page to developer hub with same content from the documentation
Rationale
How has this been tested?