contract_manager: @certusone/wormhole-sdk -> @wormhole-foundation/sdk#3760
Draft
matej-douro wants to merge 1 commit into
Draft
contract_manager: @certusone/wormhole-sdk -> @wormhole-foundation/sdk#3760matej-douro wants to merge 1 commit into
contract_manager: @certusone/wormhole-sdk -> @wormhole-foundation/sdk#3760matej-douro wants to merge 1 commit into
Conversation
The certusone SDK is deprecated for a long time already, and proto-web
sub-package imports `long` without declaring
it as a dependency, causing a MODULE_NOT_FOUND crash under pnpm's strict
package isolation. If things go well, we can follow suit with xc_admin
packages.
- governance.ts: swap certusone Solana PDA helpers for the identical
functions from @wormhole-foundation/sdk-solana-core (utils namespace)
- executor.ts, sui.ts, scripts: replace parseVaa with
deserialize("Uint8Array", ...) from
@wormhole-foundation/sdk-definitions
- executor.ts: use chainToChainId from @wormhole-foundation/sdk-base for
the emitterChain numeric comparison; use BigInt() for sequence
comparison to avoid precision loss
- sui.ts, iota.ts: inline uint8ArrayToBCS using @mysten/sui/bcs and
@iota/iota-sdk/bcs respectively
- remove preserve-native-fetch.ts: the workaround for near-api-js@1.x
clobbering globalThis.fetch is no longer needed; near-api-js@3.x
(direct dep) uses a nullish-coalescing fallback and never overwrites
it
|
The latest updates on your projects. Learn more about Vercel for GitHub.
4 Skipped Deployments
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
governance.ts: swap certusone Solana PDA helpers for the identical functions from@wormhole-foundation/sdk-solana-coreexecutor.ts,sui.ts, scripts: replaceparseVaawithdeserialize("Uint8Array", ...)from@wormhole-foundation/sdk-definitionsexecutor.ts: usechainToChainIdfrom@wormhole-foundation/sdk-basefor theemitterChaincomparisonsui.ts,iota.ts: inlineuint8ArrayToBCSusing@mysten/sui/bcsand@iota/iota-sdk/bcsrespectivelypreserve-native-fetch.ts: the workaround fornear-api-js@1.xclobberingglobalThis.fetchis no longer needed;near-api-js@3.x(direct dep) uses a nullish-coalescing fallback and never overwrites itRationale
The
@certusone/wormhole-sdkis already deprecated for a long time, and proto-web sub-package importslongwithout declaring it as a dependency, causing aMODULE_NOT_FOUNDcrash under pnpm. If things go well, we can follow suit withxc_adminpackages.How has this been tested?