-
Notifications
You must be signed in to change notification settings - Fork 346
docs(push-feeds): refresh pro_compatible_status and drop Avalanche carve-out #3875
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -24,12 +24,8 @@ const PRO_COMPATIBLE_DOCS_URL = "/price-feeds/core/upgrade/preparing"; | |
| * GET https://pyth.dourolabs.app/hermes/v2/price_feeds | ||
| * 2. For each feed, set "available" if its `id` is present in that listing, | ||
| * otherwise "coming_soon". | ||
| * 3. Avalanche carve-out: every Avalanche feed is pinned to "coming_soon" | ||
| * regardless of the listing, because Pro-compatible push feeds are not | ||
| * deployed for that chain (no deployment-pro-compatible.yaml). See the | ||
| * `_comment` in data/evm/avalanche-mainnet.json. | ||
| * | ||
| * Last refreshed 2026-06-23. To refresh, re-run the steps above. | ||
| * Last refreshed 2026-07-03. To refresh, re-run the steps above. | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
This refresh note now leaves only the generic Hermes-ID derivation, but Avalanche still has no Useful? React with 👍 / 👎. |
||
| */ | ||
| type ProCompatibleStatus = "available" | "coming_soon"; | ||
|
|
||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚩 Avalanche guard rail removed without replacement
The old
_commentinavalanche-mainnet.jsonand step 3 in the JSDoc (SponsoredFeedsTable/index.tsx:27-31before this PR) served as an explicit warning to future maintainers: "Do NOT auto-derive this field from the Hermes listing for this file." This guard rail existed because Pro-compatible push feeds are reportedly not deployed for Avalanche (nodeployment-pro-compatible.yaml). The PR removes both the JSON comment and the JSDoc step, but the Avalanche feed still has"coming_soon". Without the guard rail, a future data refresh could accidentally flip Avalanche to"available"if the feed ID appears in the Hermes listing, even though the chain doesn't support Pro-compatible push feeds. If the underlying deployment situation for Avalanche hasn't changed, consider preserving some form of documentation (e.g. a simpler comment in the JSON or the JSDoc) to prevent accidental promotion.(Refers to lines 1-12)
Was this helpful? React with 👍 or 👎 to provide feedback.